Systemd cleanup in distro #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses systemd so fits better on distro. If systemd does not exist on the instance skip info.
|
@rjschwei I know we agreed the other route. However, after thinking it over I think the code is easier to read and understand if we maintain the vm info method in distro class. And we already have SysvInit support so no reason to drop it for now. |
|
@smarlowucf fair enough but then it should at least be in the distro base class and not in the sles implementation. I know we don't have rhel, debian etc. specific implementations at this point, but the systemd calls, while systemd version specific are distro agnostic. By putting the implementation into sles you imply that only sles has systemd-analyze and tha is just not correct. Please consider putting the implementation into the base class. |
Only if init system isn't already set, attempt to retrieve and set the value.
smarlowucf
force-pushed
the
systemd-cleanup
branch
from
6db2225
to
a0bd40d
Compare
|
Okay, moved them to base class and rebased the PR. |
rjschwei
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move collect vm info into distro to maintain consistency in architecture. Maintain init system check to maintain support for SysvInit.